mirror of
https://github.com/luxfi/bridge.git
synced 2026-09-24 00:26:46 +00:00
fix(bridge): one icon set — Lucide, one version, no hand-drawn second set
The repo resolved three majors of the same set at once — 0.307.0 (via @luxdefi/ui), 0.456.0 (the catalog, used by bridge3) and 1.16.0 (pinned directly by explorer). Same import name, three different drawings. Every app now takes lucide from `catalog:`, and an override collapses the transitive copy, so one version resolves for the whole tree. app/bridge3/app/components/icons/ was a second set wearing the first one's clothes: avatar/bag/left-arrow/right-arrow were hand-drawn, typed as LucideProps, off-grid (17x21, 9x16, 1019x1281) and filled rather than stroked — three of them with `fill="white"` baked into the path, so they were invisible on a light background and could never take the theme. None had a consumer. Deleted; Lucide draws all four (User, ShoppingBag, ChevronLeft, ChevronRight). What stays in that directory is not an icon set: the Lux mark and the third-party network marks are logos, and logos are not glyphs. explorer also declared @heroicons/react and heroicons with zero imports of either — a set you cannot see is still a set you can reach for. Co-authored-by: Hanzo Dev <[email protected]>
This commit is contained in:
Hanzo Dev
@@ -1,11 +0,0 @@
|
||||
import React from 'react'
|
||||
import { type LucideProps } from 'lucide-react'
|
||||
|
||||
const Avatar: React.FC<LucideProps> = (props: LucideProps) => (
|
||||
<svg width="17" height="21" viewBox="0 0 17 21" fill="none" xmlns="http://www.w3.org/2000/svg" {...props}>
|
||||
<path d="M8.66112 10.3544C6.14668 10.3544 4.32664 6.91073 4.32664 4.59206C4.32664 2.12213 6.27238 0.115723 8.66112 0.115723C11.0499 0.115723 12.9956 2.12514 12.9956 4.59206C12.9956 6.91398 11.1756 10.3544 8.66112 10.3544ZM8.66112 1.1542C6.82539 1.1542 5.33242 2.69703 5.33242 4.59185C5.33242 6.65402 6.94715 9.31553 8.66112 9.31553C10.3761 9.31553 11.9898 6.65387 11.9898 4.5925C11.9898 2.69668 10.4969 1.15398 8.66112 1.15398V1.1542Z" fill="white" />
|
||||
<path d="M6.79776 11.3345H10.5242C13.7802 11.3345 16.4302 14.0712 16.4302 17.4338C16.4302 19.0831 15.1297 20.423 13.5356 20.423H3.78923C2.19216 20.423 0.894689 19.0831 0.894689 17.4338C0.893706 14.0712 3.54156 11.3345 6.79776 11.3345ZM3.78819 19.3844H13.5337C14.5749 19.3844 15.4225 18.509 15.4225 17.4338C15.4225 14.6453 13.2253 12.3731 10.5223 12.3731H6.79862C4.0956 12.3731 1.89839 14.6423 1.89839 17.4338C1.89937 18.509 2.74701 19.3844 3.78816 19.3844H3.78819Z" fill="white" />
|
||||
</svg>
|
||||
)
|
||||
|
||||
export default Avatar
|
||||
@@ -1,10 +0,0 @@
|
||||
import React from 'react'
|
||||
import { type LucideProps } from 'lucide-react'
|
||||
|
||||
const BagIcon: React.FC<LucideProps> = (props: LucideProps) => (
|
||||
<svg fill="none" viewBox="0 0 1019 1281" {...props}>
|
||||
<path d="m977.243 365.553h-175.407v-90.629c0-151.923-131.968-274.924-292.334-274.924-160.367 0-292.337 123.002-292.337 274.924v90.629h-175.4023c-23.3886 0-41.7627 17.051-41.7627 38.756v775.121c0 55.8 48.4456 100.76 108.582 100.76h801.84c60.138 0 108.578-44.96 108.578-100.76v-775.121c0-21.705-18.37-38.756-41.757-38.756zm-676.553-90.629c0-108.517 93.546-196.9408 208.812-196.9408 115.265 0 208.813 88.4218 208.813 196.9408v89.08h-417.625z" fill="currentColor"/>
|
||||
</svg>
|
||||
)
|
||||
|
||||
export default BagIcon
|
||||
@@ -1,6 +1,9 @@
|
||||
export { default as Avatar } from './avatar'
|
||||
export { default as Bag } from './bag-icon'
|
||||
export { default as LeftArrow } from './left-arrow'
|
||||
export { default as LuxLogo } from './lux-logo'
|
||||
export { default as RightArrow } from './right-arrow'
|
||||
export { default as SocialIcon, type SocialIconProps } from './social-icon'
|
||||
// Not an icon set — the two marks Lucide does not draw.
|
||||
//
|
||||
// UI glyphs come from Lucide (`lucide-react`, one version, pinned in the
|
||||
// workspace catalog). What lives here is brand identity: the Lux mark, and the
|
||||
// third-party network marks, which are logos and belong to their owners.
|
||||
//
|
||||
// A glyph added here would be a second set. Reach for Lucide instead.
|
||||
export { default as LuxLogo } from './lux-logo'
|
||||
export { default as SocialIcon, type SocialIconProps } from './social-icon'
|
||||
|
||||
@@ -1,11 +0,0 @@
|
||||
import React from 'react'
|
||||
import { type LucideProps } from 'lucide-react'
|
||||
|
||||
const LeftArrow: React.FC<LucideProps> = (props: LucideProps) => (
|
||||
<svg width="10" height="16" viewBox="0 0 10 16" fill="none" xmlns="http://www.w3.org/2000/svg" {...props}>
|
||||
<path d="M1.06975 7.44328C0.679224 7.83381 0.679224 8.46697 1.06975 8.8575L7.43371 15.2215C7.82423 15.612 8.4574 15.612 8.84792 15.2215C9.23845 14.8309 9.23845 14.1978 8.84792 13.8072L3.19107 8.15039L8.84792 2.49354C9.23845 2.10301 9.23845 1.46985 8.84792 1.07932C8.4574 0.688798 7.82423 0.688798 7.43371 1.07932L1.06975 7.44328ZM1.77686 9.15039H2.49037V7.15039H1.77686V9.15039Z" fill="white"/>
|
||||
</svg>
|
||||
)
|
||||
|
||||
export default LeftArrow
|
||||
|
||||
@@ -1,10 +0,0 @@
|
||||
import React from 'react'
|
||||
import { type LucideProps } from 'lucide-react'
|
||||
|
||||
const RightArrow: React.FC<LucideProps> = (props: LucideProps) => (
|
||||
<svg width="9" height="16" viewBox="0 0 9 16" fill="none" xmlns="http://www.w3.org/2000/svg" {...props}>
|
||||
<path d="M8.33797 7.58293C8.72849 7.97346 8.72849 8.60662 8.33797 8.99715L1.97401 15.3611C1.58348 15.7516 0.950316 15.7516 0.559792 15.3611C0.169267 14.9706 0.169267 14.3374 0.559792 13.9469L6.21665 8.29004L0.559792 2.63318C0.169267 2.24266 0.169267 1.6095 0.559792 1.21897C0.950316 0.828447 1.58348 0.828447 1.97401 1.21897L8.33797 7.58293ZM7.63086 9.29004H6.91734V7.29004H7.63086V9.29004Z" fill="white"/>
|
||||
</svg>
|
||||
)
|
||||
|
||||
export default RightArrow
|
||||
+55
-55
@@ -1,55 +1,55 @@
|
||||
{
|
||||
"name": "@luxbridge/app-v3",
|
||||
"version": "1.0.0",
|
||||
"private": true,
|
||||
"scripts": {
|
||||
"build": "remix vite:build",
|
||||
"dev": "remix vite:dev",
|
||||
"start": "remix-serve ./build/server/index.js",
|
||||
"tc": "tsc",
|
||||
"typecheck": "tsc",
|
||||
"clean": "rm -rf ./node_modules && rm -rf ./vercel",
|
||||
"clean:all": "pnpm -w clean:all && rm -rf ./vercel"
|
||||
},
|
||||
"sideEffects": false,
|
||||
"type": "module",
|
||||
"dependencies": {
|
||||
"@hanzo/ui": "catalog:",
|
||||
"@luxfi/core": "catalog:",
|
||||
"@luxfi/menu-icons": "1.0.2",
|
||||
"@remix-run/node": "^2.15.1",
|
||||
"@remix-run/react": "^2.15.1",
|
||||
"@remix-run/route-config": "^2.15.2",
|
||||
"@remix-run/serve": "^2.15.1",
|
||||
"@vercel/analytics": "^1.4.1",
|
||||
"@vercel/remix": "^2.15.1",
|
||||
"axios": "^1.7.9",
|
||||
"isbot": "^4",
|
||||
"lucide-react": "catalog:",
|
||||
"mobx": "^6.12.3",
|
||||
"mobx-react-lite": "^4.0.7",
|
||||
"mobx-utils": "^6.1.0",
|
||||
"motion": "^11.15.0",
|
||||
"react": "catalog:",
|
||||
"react-dom": "catalog:",
|
||||
"react-social-icons": "^6.18.0",
|
||||
"use-debounce": "^10.0.4"
|
||||
},
|
||||
"devDependencies": {
|
||||
"@originjs/vite-plugin-commonjs": "^1.0.3",
|
||||
"@remix-run/dev": "^2.15.1",
|
||||
"@remix-run/server-runtime": "^2.15.1",
|
||||
"@types/react": "catalog:",
|
||||
"@types/react-dom": "catalog:",
|
||||
"@types/uuid": "^10.0.0",
|
||||
"autoprefixer": "^10.4.20",
|
||||
"postcss": "^8.4.49",
|
||||
"tailwindcss": "catalog:",
|
||||
"typescript": "catalog:",
|
||||
"vite": "5.4.11",
|
||||
"vite-tsconfig-paths": "5.1.2"
|
||||
},
|
||||
"engines": {
|
||||
"node": "20.x"
|
||||
}
|
||||
}
|
||||
{
|
||||
"name": "@luxbridge/app-v3",
|
||||
"version": "1.0.1",
|
||||
"private": true,
|
||||
"scripts": {
|
||||
"build": "remix vite:build",
|
||||
"dev": "remix vite:dev",
|
||||
"start": "remix-serve ./build/server/index.js",
|
||||
"tc": "tsc",
|
||||
"typecheck": "tsc",
|
||||
"clean": "rm -rf ./node_modules && rm -rf ./vercel",
|
||||
"clean:all": "pnpm -w clean:all && rm -rf ./vercel"
|
||||
},
|
||||
"sideEffects": false,
|
||||
"type": "module",
|
||||
"dependencies": {
|
||||
"@hanzo/ui": "catalog:",
|
||||
"@luxfi/core": "catalog:",
|
||||
"@luxfi/menu-icons": "1.0.2",
|
||||
"@remix-run/node": "^2.15.1",
|
||||
"@remix-run/react": "^2.15.1",
|
||||
"@remix-run/route-config": "^2.15.2",
|
||||
"@remix-run/serve": "^2.15.1",
|
||||
"@vercel/analytics": "^1.4.1",
|
||||
"@vercel/remix": "^2.15.1",
|
||||
"axios": "^1.7.9",
|
||||
"isbot": "^4",
|
||||
"lucide-react": "catalog:",
|
||||
"mobx": "^6.12.3",
|
||||
"mobx-react-lite": "^4.0.7",
|
||||
"mobx-utils": "^6.1.0",
|
||||
"motion": "^11.15.0",
|
||||
"react": "catalog:",
|
||||
"react-dom": "catalog:",
|
||||
"react-social-icons": "^6.18.0",
|
||||
"use-debounce": "^10.0.4"
|
||||
},
|
||||
"devDependencies": {
|
||||
"@originjs/vite-plugin-commonjs": "^1.0.3",
|
||||
"@remix-run/dev": "^2.15.1",
|
||||
"@remix-run/server-runtime": "^2.15.1",
|
||||
"@types/react": "catalog:",
|
||||
"@types/react-dom": "catalog:",
|
||||
"@types/uuid": "^10.0.0",
|
||||
"autoprefixer": "^10.4.20",
|
||||
"postcss": "^8.4.49",
|
||||
"tailwindcss": "catalog:",
|
||||
"typescript": "catalog:",
|
||||
"vite": "5.4.11",
|
||||
"vite-tsconfig-paths": "5.1.2"
|
||||
},
|
||||
"engines": {
|
||||
"node": "20.x"
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
{
|
||||
"name": "@luxbridge/explorer",
|
||||
"version": "1.0.0",
|
||||
"version": "1.0.1",
|
||||
"private": true,
|
||||
"scripts": {
|
||||
"dev": "next dev",
|
||||
@@ -13,7 +13,6 @@
|
||||
},
|
||||
"dependencies": {
|
||||
"@headlessui/react": "^2.2.10",
|
||||
"@heroicons/react": "^2.2.0",
|
||||
"@luxdefi/ui": "0.5.10",
|
||||
"@next/mdx": "16.2.6",
|
||||
"@radix-ui/react-accordion": "^1.2.12",
|
||||
@@ -25,8 +24,7 @@
|
||||
"clsx": "^2.1.1",
|
||||
"copy-to-clipboard": "^4.0.2",
|
||||
"framer-motion": "^12.40.0",
|
||||
"heroicons": "^2.2.0",
|
||||
"lucide-react": "^1.16.0",
|
||||
"lucide-react": "catalog:",
|
||||
"next": "catalog:",
|
||||
"react": "catalog:",
|
||||
"react-dom": "catalog:",
|
||||
|
||||
+3
-2
@@ -1,6 +1,6 @@
|
||||
{
|
||||
"name": "bridge",
|
||||
"version": "1.1.0",
|
||||
"version": "1.1.1",
|
||||
"description": "Lux Bridge - Decentralized cross-chain bridge using MPC",
|
||||
"packageManager": "[email protected]",
|
||||
"main": "index.js",
|
||||
@@ -37,7 +37,8 @@
|
||||
]
|
||||
},
|
||||
"overrides": {
|
||||
"keccak": "3.0.4"
|
||||
"keccak": "3.0.4",
|
||||
"lucide-react": "1.16.0"
|
||||
}
|
||||
},
|
||||
"devDependencies": {
|
||||
|
||||
Generated
+18
-57
+4
-1
@@ -11,7 +11,10 @@ catalog:
|
||||
'@types/node': 20.14.15
|
||||
'@types/react': 18.3.12
|
||||
'@types/react-dom': 18.3.1
|
||||
lucide-react: 0.456.0
|
||||
# One icon set, one version. Every app takes lucide from `catalog:` — pinning
|
||||
# it per app is how this repo ended up resolving three majors at once, and the
|
||||
# same name is a different drawing across them.
|
||||
lucide-react: 1.16.0
|
||||
react-hook-form: 7.51.4
|
||||
next: 14.2.16
|
||||
react: 18.3.1
|
||||
|
||||
Reference in New Issue
Block a user