security: role-based permissions for IAM users in RequirePermission

IAM-authenticated users no longer get implicit admin access. RequirePermission
now checks X-User-Roles header for the required permission. Default IAM users
without explicit roles get read + trade only. Admin endpoints require explicit
admin role in JWT claims.

Adds hasRole() helper for comma-separated role string parsing.
This commit is contained in:
2026-03-30 20:11:32 -07:00
parent 32ee53d6f5
commit 27ad8b7090
+32 -3
View File
@@ -116,12 +116,31 @@ func Middleware(store *Store) func(http.Handler) http.Handler {
}
// RequirePermission returns middleware that checks for a specific permission.
// IAM users are authorized based on roles from the X-User-Roles header (set by Gateway
// from JWT claims). Admin role grants all permissions. Regular users get "read" and "trade".
func RequirePermission(store *Store, perm string) func(http.Handler) http.Handler {
return func(next http.Handler) http.Handler {
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
// IAM auth — Gateway-validated user has all permissions
if r.Header.Get("X-User-Id") != "" || r.Header.Get("X-IAM-User-Id") != "" {
next.ServeHTTP(w, r)
// IAM auth — check roles propagated by Gateway from JWT claims
userId := r.Header.Get("X-User-Id")
if userId == "" {
userId = r.Header.Get("X-IAM-User-Id")
}
if userId != "" {
roles := r.Header.Get("X-User-Roles")
if hasRole(roles, perm) || hasRole(roles, "admin") {
next.ServeHTTP(w, r)
return
}
// Default permissions for authenticated IAM users without explicit roles:
// read and trade are allowed, admin-only endpoints are denied.
if perm == "read" || perm == "trade" {
next.ServeHTTP(w, r)
return
}
w.Header().Set("Content-Type", "application/json")
w.WriteHeader(http.StatusForbidden)
w.Write([]byte(`{"error":"insufficient permissions"}`))
return
}
key := extractAPIKey(r)
@@ -143,6 +162,16 @@ func RequirePermission(store *Store, perm string) func(http.Handler) http.Handle
}
}
// hasRole checks if a comma-separated roles string contains the given role.
func hasRole(roles, role string) bool {
for _, r := range strings.Split(roles, ",") {
if strings.TrimSpace(r) == role {
return true
}
}
return false
}
func extractAPIKey(r *http.Request) string {
// Check Authorization header
auth := r.Header.Get("Authorization")