100 Commits
Author SHA1 Message Date
James Peterandzeekay 11fa2750eb fix(tui/auto-drive): block resume while auto-resolve pending 2026-07-31 20:35:36 -07:00
James Peterandzeekay f9b95602b9 fix(tui/tools): group agent and browser tool cells 2026-07-31 20:35:35 -07:00
James Peter 30a0a065be Merge branch 'merge/code-branch-20251007-113259' into main 2025-10-08 10:27:28 +10:00
James Peter ba3dd4b8fa fix(history): dedupe assistant messages across finalize/restore 2025-10-07 22:46:12 +10:00
James Peter a6774dbd1f Merge branch 'code-branch-20251007-104544' into main 2025-10-07 21:51:56 +10:00
James Peter 3bc12aeb03 merge local main into code-branch-20251007-104544 before merge 2025-10-07 21:51:56 +10:00
James Peter aa6aaae817 fix(tui/history): clear suppressed exec cells 2025-10-07 21:29:04 +10:00
James Peter 8d138ed9bd UX: match resume hint to coder alias 2025-10-07 21:12:35 +10:00
James Peter 51e8ca93aa Merge branch 'code-branch-20251007-101600' into main 2025-10-07 21:01:44 +10:00
James Peter cd1aa8dc96 fix(tui/resume): avoid duplicate assistant cells on replay 2025-10-07 20:50:32 +10:00
James Peter 382236f47b fix(mcp-server): track acp session_set_model rename 2025-10-07 20:02:39 +10:00
James Peter 2a71c32f13 Merge branch 'code-branch-20251006-101336' into main 2025-10-07 19:44:50 +10:00
James Peter ea441d4833 Merge remote-tracking branch 'origin/main' into code-branch-20251006-101336 2025-10-07 19:44:05 +10:00
James Peter c20501342e test(tui): document vt100 harness and drop flaky regressions 2025-10-07 19:24:36 +10:00
James Peter e9ab41f892 Merge branch 'code-branch-20251006-215207' into main 2025-10-07 13:59:43 +10:00
James Peter abfaf1161c fix(core/rollout): keep agent events untouched when resuming 2025-10-07 13:28:35 +10:00
James Peter a8937812a7 fix(core/rollout): preserve user attachments when resuming 2025-10-07 13:20:26 +10:00
James Peter 48d345db86 test: reintroduce minimal tests 2025-10-07 13:02:00 +10:00
James Peter c494b8c3bb test(config): wrap env var calls in EnvVarGuard drop 2025-10-07 12:40:02 +10:00
James Peter 1e5f7c1391 test(tui/vt100): add explore/reasoning repro harness 2025-10-07 12:31:39 +10:00
James Peter 2e14cf2947 Merge branch 'code-branch-20251006-192649' into main 2025-10-07 07:46:55 +10:00
James Peter d157fff687 merge local main into code-branch-20251006-192649 before merge 2025-10-07 07:46:55 +10:00
James Peter 296a65eba4 Merge branch 'code-branch-20251006-105834' into main 2025-10-07 07:46:37 +10:00
James Peter 6834025471 merge local main into code-branch-20251006-105834 before merge 2025-10-07 07:46:37 +10:00
James Peter 60f0eef0aa merge main into code-branch-20251006-105834 before merge 2025-10-07 07:46:37 +10:00
James Peter 062f0367cd Merge branch 'code-branch-20251006-105837' into main 2025-10-07 07:45:19 +10:00
James Peter e036d07786 merge local main into code-branch-20251006-105837 before merge 2025-10-07 07:45:19 +10:00
James Peter dba58c7edf merge main into code-branch-20251006-105837 before merge 2025-10-07 07:45:19 +10:00
James Peter 77dcba659c fix(tui/resume): bias provider order after restore
- track expected next request ordinal when loading resume snapshots
- add dynamic bias for incoming OrderMeta so resumed turns append
- ensure queued interrupts and exec tools reuse biased order keys
- add regression test confirming resumed output lands at tail

Closes #319
2025-10-07 06:35:44 +10:00
James Peter dd99724659 test(tui/vt100): reproduce bottom clipping regression 2025-10-07 06:07:10 +10:00
James Peter 21a44e68cb fix(tui/spinner): clear footer when agent status stalls
closes #316
2025-10-07 05:43:12 +10:00
James Peter 2459f42769 fix(tui/trust): honor allow_git_writes in trusted workspaces
Closes #314.
2025-10-07 05:22:56 +10:00
James Peter 676a8b6514 Merge branch 'code-branch-20251006-110017' into main 2025-10-07 05:21:30 +10:00
James Peter 21333e8dfe merge local main into code-branch-20251006-110017 before merge 2025-10-07 05:21:30 +10:00
James Peter 6029af9914 merge main into code-branch-20251006-110017 before merge 2025-10-07 05:21:30 +10:00
James Peter b859508134 docs(triage): clarify closing instruction 2025-10-07 04:53:31 +10:00
James Peter 2707dae235 Merge branch 'code-branch-20251006-105956' into main 2025-10-07 04:45:26 +10:00
James Peter 27680a4f7e Merge remote-tracking branch 'origin/main' into code-branch-20251006-105956 2025-10-07 04:44:49 +10:00
James Peter 41532c4e08 test(tui): add vt100 snapshot harness and baselines 2025-10-07 04:26:06 +10:00
James Peter 0806c20a85 fix(tui/composer): support backslash continuation
Fixes #312
2025-10-07 04:18:19 +10:00
James Peter a57ca290e7 fix(core/config): honor legacy AGENTS.md fallback
Fixes #322.
2025-10-07 04:18:18 +10:00
James Peter 2443f1bbfc triage prompt 2025-10-06 20:50:19 +10:00
James Peter d6f377d2f3 Merge origin/main: adopt remote release metadata 2025-10-06 20:30:44 +10:00
James Peter 81eac275c8 fix(mcp): validate stdio command on PATH; improve spawn error context. Fixes #302 2025-10-06 20:23:49 +10:00
James Peter 6b62985933 fix(release): ensure release notes header matches tag; add guard check. Fixes #326 2025-10-06 20:23:44 +10:00
James Peter f7a49d2535 fix(mcp): validate stdio command on PATH; improve spawn error context. Fixes #302 2025-10-06 19:59:07 +10:00
James Peter a1b19f9ab1 fix(release): ensure release notes header matches tag; add guard check. Fixes #326 2025-10-06 19:36:52 +10:00
James Peter 2b871ab54b prompt tweak 2025-10-06 19:23:29 +10:00
James Peter 2b58038eeb ci(release): run nextest with locked debug profile 2025-10-06 18:32:07 +10:00
James Peter e53db0d243 ci(release): reuse dev-fast build for tests and cleanup target 2025-10-06 18:14:50 +10:00
James Peter c71c5cbb32 fix(rollout): prefer rollout files when resuming 2025-10-06 17:27:22 +10:00
James Peter ab3d651a23 test: run nextest in release and harden smokes 2025-10-06 16:26:26 +10:00
James Peter 897d3cb8f0 Merge branch 'code-branch-20251006-020831' into main 2025-10-06 14:14:08 +10:00
James Peter 7947f6fa8e merge local main into code-branch-20251006-020831 before merge 2025-10-06 14:14:08 +10:00
James Peter d8f5e50cde merge main into code-branch-20251006-020831 before merge 2025-10-06 14:14:07 +10:00
James Peter cef3359113 fix(tui): stabilize history ordering and scrollback 2025-10-06 14:05:00 +10:00
James Peter d206df5e9f Merge branch 'code-branch-20251006-020602' into main 2025-10-06 13:50:16 +10:00
James Peter b92970c502 merge main into code-branch-20251006-020602 before merge 2025-10-06 13:50:16 +10:00
James Peter 6e9763fb05 fix(core/tests): restore cargo test coverage 2025-10-06 13:49:35 +10:00
James Peter 1010377c10 chore(codex-rs): align mirror with parallel tool API 2025-10-06 12:04:29 +10:00
James Peter ac1920dcc0 fix(ci): restore execpolicy cli and test deps 2025-10-06 11:46:01 +10:00
James Peter 44458d2d0e Merge upstream/main: adopt tool parallelism and exec formatting 2025-10-06 11:19:57 +10:00
James Peter 4cd15413ab Merge branch 'code-branch-20251005-231240' into main 2025-10-06 10:21:48 +10:00
James Peter 96d1fad448 merge local main into code-branch-20251005-231240 before merge 2025-10-06 10:21:48 +10:00
James Peter 175a5eac7d refactor(upstream): re-export crates and prune docs 2025-10-06 10:21:27 +10:00
James Peter ac9590b7ba Merge branch 'code-branch-20251006-000111' into main 2025-10-06 10:20:49 +10:00
James Peter a1f65904d1 merge local main into code-branch-20251006-000111 before merge 2025-10-06 10:20:49 +10:00
James Peter 49cf2dfa58 Merge branch 'code-branch-20251006-000101' into main 2025-10-06 10:16:01 +10:00
James Peter a3d14642e8 fix(agents): show cloud builtin in /agents UI 2025-10-06 10:14:03 +10:00
James Peter a1965499d3 fix(ci-tests): call --tests for migrated crates 2025-10-06 10:09:39 +10:00
James Peter 4cf2ddf493 Merge branch 'code-branch-20251005-232038' into main 2025-10-06 09:58:40 +10:00
James Peter 2077e7be5d fix(tui/explore): hold exploring header off rendered cells 2025-10-06 09:58:16 +10:00
James Peter 536c1aec8a chore(upstream): strip code branding in docs during diff 2025-10-06 09:07:04 +10:00
James Peter 5f74f7ca81 chore(upstream): drop .DS_Store noise in diff-crates 2025-10-06 09:05:14 +10:00
James Peter bc744fad6f chore(upstream): ignore code prefix in diff crate comparisons 2025-10-06 09:01:17 +10:00
James Peter d5a124fd3a chore(upstream): normalize crate rename noise in diff-crates 2025-10-06 08:59:57 +10:00
James Peter 0089b863d8 fix(workflows): restore release and point to code-rs 2025-10-06 08:54:53 +10:00
James Peter d3b4b15eb5 chore(tui): remove legacy overlay stack 2025-10-06 08:48:22 +10:00
James Peter 01795513fe chore(tui): drop vt100-tests flag and sync docs 2025-10-06 08:40:54 +10:00
James PeterandHanzo Dev 584fe44ee0 docs: add comprehensive session summary for 2025-10-06
Created detailed summary document capturing all work completed during
the Phase 1 cleanup session.

Session Achievements:
- Completed Phase 1-3: Baseline & Tooling, Crate Adoption, Fork Cleanup
- Removed 35,000 lines of legacy test code (106 files)
- Adopted upstream crates (mcp-client, responses-api-proxy)
- Audited feature flags and module usage (all active, no dead code)
- Documented test scaffolding patterns (ChatWidgetHarness)
- Created 5 new migration/maintenance documentation files

Metrics Summary:
- Test files: 205 → 99 (-52%)
- Test code lines: 46,300 → 11,300 (-76%)
- Orphaned modules: 6 → 0 (100% removed)
- Build time: 1m 30s (no regression)
- Documentation: 5 new comprehensive guides

Commits Created (4):
1. Legacy test retirement and upstream crate adoption
2. Feature flag and module audit completion
3. Test scaffolding patterns documentation
4. Roadmap update with completion status

Next Steps Identified:
- Checkout upstream to codex-rs/ for test porting
- Begin Phase 2: Port 6 critical core runtime tests
- Begin Phase 3: Port 3 TUI rendering tests
- Expand smoke test coverage using documented patterns

Status: Phase 1 Complete ✅ | Phase 2-4 Ready 🔄 | Upstream Checkout Needed 📋

Session captured all deliverables, metrics, lessons learned, and blockers
for future reference and continuity.

Co-authored-by: Hanzo Dev <[email protected]>
2025-10-06 05:25:36 +10:00
James PeterandHanzo Dev 8350b07e33 docs: update roadmap with Phase 1 completion status
Updated ROADMAP.md to reflect all completed Phase 1 work and reorganize
next actions with completion markers.

Completed (2025-10-06):
- Feature flag audit: code-fork properly used, gates 12 TUI extensions
- Module usage audit: All core and TUI modules actively used
- Test scaffolding documentation: ChatWidgetHarness patterns documented
- Dead code inventory: Comprehensive audit summary added

Active Work:
- Phase 2: Core runtime test porting (blocked on codex-rs/ checkout)
- Upstream diff review (requires codex-rs/ directory setup)
- Smoke test expansion (ongoing, following documented patterns)

Next Steps:
- Checkout upstream to codex-rs/ for diff tracking and test porting
- Begin porting 9 critical tests per legacy-tests-retirement.md
- Expand smoke test coverage using documented harness patterns

All Phase 1-3 objectives complete (Baseline & Tooling, Crate Adoption,
Fork Cleanup). Phase 4 (Test Suite Rebuild) in progress with scaffolding
complete and porting plan documented.

Co-authored-by: Hanzo Dev <[email protected]>
2025-10-06 05:23:48 +10:00
James PeterandHanzo Dev 94135c92f7 docs: document test scaffolding patterns and helpers
Added comprehensive documentation for the new test scaffolding infrastructure
created for code-rs smoke tests.

Test Scaffolding Documentation:
- ChatWidgetHarness: Test harness for widget testing without terminal I/O
- Assertion helpers: Pre-built assertions for common test patterns
- Usage examples: Real-world test patterns from ui_smoke.rs
- Best practices: Guidelines for writing maintainable smoke tests
- Extension guide: How to add new helpers and harness variants

Helper Functions Documented:
- ChatWidgetHarness::new() - Create test harness with defaults
- harness.handle_event() - Send protocol events to widget
- harness.drain_events() - Collect emitted AppEvents
- assert_has_insert_history() - Verify history insertion
- assert_has_background_event_containing() - Check background events
- assert_has_terminal_chunk_containing() - Verify terminal output
- assert_has_codex_event() - Check CodexEvent emission
- assert_no_events() - Verify no events emitted

Future Infrastructure:
- AppHarness for full app-level testing
- ExecutorHarness for command lifecycle testing
- MCPHarness for MCP server interaction testing
- VT100 replay tests for rendering regression testing

This documentation enables developers to write new smoke tests following
established patterns and expand test coverage incrementally.

Related: chatwidget::smoke_helpers in code-rs/tui/src/chatwidget/smoke_helpers.rs

Co-authored-by: Hanzo Dev <[email protected]>
2025-10-06 05:23:09 +10:00
James PeterandHanzo Dev c894d61233 docs: complete feature flag and module audit
Completed comprehensive audit of code-fork feature flag usage and module
organization across code-rs workspace.

Audit Results:
- Feature flags: All flags actively used, no unused flags detected
  - code-fork: Enabled by default, gates 12 fork-specific TUI extensions
  - vt100-tests: Retained for future test scaffolding
  - debug-logs, dev-faults: Active for development

- Module usage: All core and TUI modules actively used
  - code-rs/core subdirs (codex/, unified_exec/, exec_command/): All active
  - code-rs/tui modules: No orphaned code detected
  - #![allow(dead_code)]: 9 files with acceptable usage (helpers, utilities)

- Dead code status: No critical dead code remaining after Phase 1 cleanup
  - 35,000+ lines removed (106 test files + 6 orphaned modules)
  - All remaining code actively used and properly integrated

Updated DEAD_CODE_INVENTORY.md with:
- Feature flag audit results and usage details
- Module usage verification for core and TUI
- Audit summary section with documentation links
- Updated success metrics reflecting Phase 1 completion

Next: Focus on porting 9 critical tests per legacy-tests-retirement.md

Co-authored-by: Hanzo Dev <[email protected]>
2025-10-06 05:20:34 +10:00
James PeterandHanzo Dev 7deab83fc3 chore: complete legacy test retirement and upstream crate adoption
This commit completes Phase 1 of the codebase cleanup plan documented in
ROADMAP.md and related migration documents.

Major changes:
- Removed legacy test suites from code-rs/ crates (~35,000 lines)
- Adopted upstream codex-mcp-client and codex-responses-api-proxy
- Deleted TUI compat layer, agent task planning docs, and orphaned modules
- Updated documentation to reflect current state and future phases

Test Coverage:
- Deleted tests from: app-server, apply-patch, chatgpt, cli, core, exec,
  login, mcp-server
- Documented 9 remaining coverage gaps requiring new tests (see
  docs/migration/legacy-tests-retirement.md)
- Preserved smoke test infrastructure in tui/tests/ui_smoke.rs

Crate Adoptions:
- mcp-client: Now re-exports codex-mcp-client with fork-specific buffer config
- responses-api-proxy: Now re-exports codex-responses-api-proxy with minimal
  wrapper
- mcp-types: Updated to use upstream types where possible

TUI Cleanup:
- Removed compat.rs ratatui adapter layer
- Deleted obsolete modules: app_backtrack, custom_terminal, scroll_view,
  text_block, transcript_app
- Archived agent_tasks/ planning docs to docs/archive/

Documentation Updates:
- ROADMAP.md: Marked Phases 1-2 complete, updated next actions
- TEST_SUITE_RESET.md: Documented Phase 1 completion
- DEAD_CODE_INVENTORY.md: Updated with deletion outcomes
- Added docs/migration/legacy-tests-retirement.md with 6-week plan
- Added docs/maintenance/prompt-architecture.md

Next Steps (Phase 2-3):
- Port critical test coverage (9 test files identified)
- Expand smoke test scenarios
- Continue upstream tracking per monthly cadence

See docs/migration/ for detailed migration status and roadmap.

Co-authored-by: Hanzo Dev <[email protected]>
2025-10-06 05:15:48 +10:00
James Peter d314420bf8 Merge branch 'code-branch-20251005-024843' 2025-10-05 20:49:49 +10:00
James Peter f2f0a07b38 docs: reset roadmap and add maintenance guides 2025-10-05 20:48:06 +10:00
James Peter f95ab56e7c Revert "refactor(tui): route ratatui imports through compat"
This reverts commit 00044c540f.
2025-10-05 19:48:52 +10:00
James Peter 00044c540f refactor(tui): route ratatui imports through compat 2025-10-05 19:27:12 +10:00
James Peter c4eaa8a5cc docs(tui): expand legacy plan and add smoke test scaffold 2025-10-05 18:34:07 +10:00
James Peter 9b09ea415a feat(tui): add compat adapter and smoke documentation 2025-10-05 17:33:29 +10:00
James Peter 754876f26d Merge branch 'code-branch-20251005-013414' 2025-10-05 12:06:02 +10:00
James Peter 2c3d9744fd chore(codex-rs): sync with upstream main 2025-10-05 12:05:06 +10:00
James Peter 627b9cc809 fix(core/git_worktree): restore cache mirror toggle 2025-10-05 12:02:23 +10:00
James Peter e293560dd6 fix(core/git_worktree): gate cache copying behind env 2025-10-05 11:32:59 +10:00
James Peter 2191b4df05 fix(branch): ignore dev-fast CLI shims 2025-10-05 11:25:00 +10:00
James Peter c23f76121c chore(build): make code workspace default 2025-10-05 10:39:13 +10:00
James Peter 3fbc0c9e7b fix(core/git-worktree): gate target cache mirroring 2025-10-05 10:38:55 +10:00
James Peter 2468d5b461 feat(core/git_worktree): mirror build caches in branch worktrees 2025-10-05 09:28:51 +10:00
James Peter 021105b512 fix(tui/auto): skip review wait when disabled 2025-10-05 09:28:37 +10:00
James Peter 62097a6894 Merge branch 'code-branch-20251004-135106' 2025-10-05 09:07:43 +10:00